Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change node to component on FE constants #2545

Merged
merged 1 commit into from
Jul 5, 2024
Merged

refactor: change node to component on FE constants #2545

merged 1 commit into from
Jul 5, 2024

Conversation

igorrCarvalho
Copy link
Contributor

This PR introduces a refactor to our front-end codebase, specifically changing the terminology from node to component in our constants. This change aims to improve code readability and maintain consistency with the terminology used throughout our application.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request javascript Pull requests that update Javascript code labels Jul 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored ✅ ❌
Pull request is made by a whitelisted user and should be ignored ❌ ❌
Pull request is submitted by a bot and should be ignored ✅ ❌
Pull request is submitted by administrators and should be ignored ❌ ❌

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages ❌ ✅
Pull request does not introduce too many changes ❌ ✅
Pull request has a valid title ✅ ✅
Pull request has mentioned issues ❌ ✅
Pull request has valid branch name ❌ ✅
Pull request should have a non-empty body ✅ ✅

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 05 Jul 24 00:47 UTC

@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed enhancement New feature or request labels Jul 5, 2024
Cristhianzl
Cristhianzl approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 5, 2024
@Cristhianzl Cristhianzl merged commit 6443354 into main Jul 5, 2024
24 checks passed
@Cristhianzl Cristhianzl deleted the refactor/nodesConstants branch July 5, 2024 12:34
carlosrcoelho pushed a commit that referenced this pull request Jul 5, 2024
@igorrCarvalho @carlosrcoelho
refactor: change node to component on FE constants (#2545)
7037c38
ogabrielluiz pushed a commit to yaitec/langflow that referenced this pull request Jul 9, 2024
@igorrCarvalho @ogabrielluiz
refactor: change node to component on FE constants (langflow-ai#2545)
4b5876c
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 10, 2024
@igorrCarvalho @nicoloboschi
refactor: change node to component on FE constants (langflow-ai#2545)
4a933c3 
(cherry picked from commit 6443354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cristhianzl Cristhianzl Cristhianzl approved these changes

@ogabrielluiz ogabrielluiz Awaiting requested review from ogabrielluiz

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorrCarvalho @Cristhianzl